Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made length of descriptions and number of timings configurable in bac… #41

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

CamillH
Copy link
Collaborator

@CamillH CamillH commented Feb 7, 2024

…kend

@CamillH CamillH requested a review from Kanti February 7, 2024 10:37
ext_conf_template.txt Outdated Show resolved Hide resolved
ext_conf_template.txt Show resolved Hide resolved
Classes/Utility/TimingUtility.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ccbe1d0) 15.70% compared to head (eb61d15) 15.78%.

Files Patch % Lines
Classes/Utility/TimingUtility.php 9.09% 10 Missing ⚠️
Classes/Service/ConfigService.php 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #41      +/-   ##
============================================
+ Coverage     15.70%   15.78%   +0.08%     
- Complexity      158      163       +5     
============================================
  Files            21       21              
  Lines           503      513      +10     
============================================
+ Hits             79       81       +2     
- Misses          424      432       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kanti Kanti merged commit 8b8d5a2 into main Feb 9, 2024
20 checks passed
@Kanti Kanti deleted the feature/configure-number-description branch February 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants